add new deterministic functions, non-retryable errors, and shutdown h… #33
Conversation
filintod
force-pushed
the
filinto/asyncio-p1
branch
from
f6f6a40 to
de68786
Compare
| self._stub = stubs.TaskHubSidecarServiceStub(channel) | ||
| self._logger = shared.get_logger("client", log_handler, log_formatter) | ||
|
|
||
| def __enter__(self): |
There was a problem hiding this comment.
add context manager option for clean closing
| # gRPC timeout mapping (pytest unit tests may pass None explicitly) | ||
| grpc_timeout = None if (timeout is None or timeout == 0) else timeout | ||
|
|
||
| # If timeout is None or 0, skip pre-checks/polling and call server-side wait directly |
There was a problem hiding this comment.
improves resource consumption on server side that might also lag behind client side
| @@ -0,0 +1,48 @@ | |||
| [mypy] | |||
There was a problem hiding this comment.
this is actually not used yet. just as reference. We'll need to run mypy and there are lots of changes required to make it pass
| pass | ||
|
|
||
|
|
||
| class NonRetryableError(Exception): |
There was a problem hiding this comment.
this is a new helper, that is present in Temporal but not us, where we can defined errors that are non-retryable so activities don't attempt to retry when raised
| next_delay_f, self._retry_policy.max_retry_interval.total_seconds() | ||
| ) | ||
| return timedelta(seconds=next_delay_f) | ||
| return timedelta(seconds=next_delay_f) |
There was a problem hiding this comment.
this fixes a bug with retry, as the login in line 400 above f datetime.utcnow() < retry_expiration: means that we should retry, but as this was badly indented if for some reason max_retry_interval is not none this was not working.
There was a problem hiding this comment.
this is also kind of mentioned in one of the gotchas in dapr/python-sdk#836, I found this bug beforehand, the other gotchas are gotchas or not-explained behavior
| @@ -0,0 +1,16 @@ | |||
| apiVersion: dapr.io/v1alpha1 | |||
There was a problem hiding this comment.
needed for e2e tests with dapr that should sub durabletask-go tests
…nistic functions similar to dotnet Signed-off-by: Filinto Duran <[email protected]>
filintod
force-pushed
the
filinto/asyncio-p1
branch
from
dd94256 to
366b2f6
Compare
1 participant
This is a split from asyncio PR #13 . Removing changes not related to asyncio changes