Skip to content

Conversation

famarting
Copy link
Contributor

Description

Updates durabletask dependency and updates CreateTimer to support passing an optional timer name

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@famarting famarting requested review from a team as code owners May 23, 2025 11:32
Copy link

codecov bot commented May 23, 2025

Codecov Report

❌ Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.12%. Comparing base (6c59092) to head (687e805).
⚠️ Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
workflow/context.go 0.00% 9 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6c59092) and HEAD (687e805). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (6c59092) HEAD (687e805)
4 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   62.52%   57.12%   -5.41%     
==========================================
  Files          56       58       +2     
  Lines        4139     4450     +311     
==========================================
- Hits         2588     2542      -46     
- Misses       1425     1771     +346     
- Partials      126      137      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Fabian Martinez <[email protected]>
Signed-off-by: Fabian Martinez <[email protected]>
@famarting famarting force-pushed the wf-support-timer-names branch from ca6e00a to 687e805 Compare August 20, 2025 11:57
@famarting famarting requested a review from mikeee August 20, 2025 11:57
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yaron2 yaron2 merged commit 6dd4349 into dapr:main Aug 20, 2025
32 of 35 checks passed
@famarting famarting deleted the wf-support-timer-names branch August 20, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants