Skip to content

Conversation

javier-aliaga
Copy link
Contributor

Description

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@javier-aliaga javier-aliaga requested review from a team as code owners August 7, 2025 10:05
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.12%. Comparing base (6c59092) to head (c384229).
⚠️ Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
client/conversation.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6c59092) and HEAD (c384229). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (6c59092) HEAD (c384229)
4 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   62.52%   57.12%   -5.41%     
==========================================
  Files          56       58       +2     
  Lines        4139     4431     +292     
==========================================
- Hits         2588     2531      -57     
- Misses       1425     1763     +338     
- Partials      126      137      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@javier-aliaga javier-aliaga force-pushed the use-rc3 branch 3 times, most recently from 3c9ec9f to 49005db Compare August 7, 2025 10:30
Signed-off-by: Javier Aliaga <[email protected]>
@javier-aliaga
Copy link
Contributor Author

@mikeee this is the same as you PR but fixes the test and other lint issues

Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to cherrypick the commit from my PR into #738 than add placeholders with panics, wydt?

@javier-aliaga
Copy link
Contributor Author

@mikeee sounds good, I will do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants