Add configuration overrides for DaprWorkflowClient and WorkflowRuntimeBuilder #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@artursouza @salaboy as I was working on this PR I have discovered that the workflow tests weren't picked up by Maven Fail Safe plugin since these were ending in Please take a look and let me know if everything is looking good. |
|
@artursouza @cicoyle and @salaboy the build 🟢, could you please review and approve. Thank you! 🙇 |
|
Great catch.. I will review and approve later today |
salaboy
approved these changes
Aug 31, 2024
|
@caniszczyk @artursouza This is ready to be merged.. please take a look, I've approved it already, but that is not enough :) |
…eBuilder Signed-off-by: Artur Ciocanu <[email protected]>
artur-ciocanu
force-pushed
the
gh-1112
branch
from
6da680f to
7a2a814
Compare
|
@salaboy as discussed I have simplified the Could you please take another look? |
artursouza
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a small limitation, it ensures that DaprWorkflowClient and WorkflowRuntimeBuilder allows configuration overrides via properties override mechanism.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1112
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: