-
Notifications
You must be signed in to change notification settings - Fork 223
feat: Support registering activities with custom name #1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Support registering activities with custom name #1431
Conversation
8a48dec
to
28f7d93
Compare
28f7d93
to
76d1666
Compare
76d1666
to
2028f95
Compare
Mmmmmm, @salaboy , let me see I think I can go a bit further and do it |
Signed-off-by: Javier Aliaga <[email protected]>
1a8a517
to
cea264a
Compare
ey @salaboy I am recovering this PR as it introduces new benefits to the sdk. Not only you can name classes it also allows using anonymous classes to register activities. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1431 +/- ##
============================================
+ Coverage 76.91% 78.56% +1.65%
- Complexity 1592 1896 +304
============================================
Files 145 234 +89
Lines 4843 5874 +1031
Branches 562 603 +41
============================================
+ Hits 3725 4615 +890
- Misses 821 937 +116
- Partials 297 322 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR allow to register activities with a custom name. This is useful in case you want to reuse activities or want to give more meaningful name to the activity, it also allow using anonymous classes (currently not supported as we are using canonical names to register and anonymous classes return null)
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: