Skip to content

Setting default props for DaprClient #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −4
Open

Setting default props for DaprClient #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...onfigure/src/main/java/io/dapr/spring/boot/autoconfigure/client/DaprClientProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@

@ConfigurationProperties(prefix = "dapr.client")
public class DaprClientProperties {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondering if an endpoints shouldn't have the port. As far as I remember there is some parsing logic in the network utils.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artur-ciocanu yeah.. I have this constant feeling that this is not aligned all over the place.. but I didn't wanted to add more changes to this PR. Maybe we need another issue to track this alignment. Right now, this is just setting the default values.

private String httpEndpoint;
private String grpcEndpoint;
private Integer httpPort;
private Integer grpcPort;
private String httpEndpoint = "http://localhost";
private String grpcEndpoint = "localhost";
private Integer httpPort = 3500;
private Integer grpcPort = 50001;
private String apiToken;

/**
Expand Down
17 changes: 17 additions & 0 deletions ...gure/src/test/java/io/dapr/spring/boot/autoconfigure/client/DaprClientPropertiesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,21 @@ public void shouldSetDaprClientPropertiesCorrectly() {
});
}

@Test
@DisplayName("Should create DaprClientProperties default values correctly")
public void shouldSetDaprClientDefaultPropertiesCorrectly() {

DaprClientProperties properties = new DaprClientProperties();

SoftAssertions.assertSoftly(softAssertions -> {
softAssertions.assertThat(properties.getGrpcEndpoint()).isEqualTo("localhost");
softAssertions.assertThat(properties.getHttpEndpoint()).isEqualTo("http://localhost");
softAssertions.assertThat(properties.getHttpPort()).isEqualTo(3500);
softAssertions.assertThat(properties.getGrpcPort()).isEqualTo(50001);
softAssertions.assertThat(properties.getApiToken()).isNull();
});
}

@Test
@DisplayName("Should map DaprClient properties correctly")
public void shouldMapDaprClientProperties() {
Expand Down Expand Up @@ -105,6 +120,8 @@ public void shouldMapDaprClientPropertiesCamelCase() {
});
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove unnecessary new lines.



@EnableConfigurationProperties(DaprClientProperties.class)
static class EnableDaprClientProperties {

Expand Down
Loading