adding new method signature plus test #1570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salaboy
force-pushed
the
1569-save-metadata
branch
from
1da2f75 to
62f1fda
Compare
salaboy
force-pushed
the
1569-save-metadata
branch
3 times, most recently
from
9746e04 to
d6fe7d5
Compare
There was a problem hiding this comment.
@salaboy nice job! I just think we should be careful not to change the incoming parameter. For example if someone would send an unmodifiable map as parameter, it will result in a runtime exception.
salaboy
force-pushed
the
1569-save-metadata
branch
5 times, most recently
from
4450500 to
a528661
Compare
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
* Force Jackson version to override the SB Jackson version Signed-off-by: Artur Ciocanu <[email protected]> * Move all the Jackson deps to parent POM. Signed-off-by: Artur Ciocanu <[email protected]> * Ensure app JAR build order Signed-off-by: Artur Ciocanu <[email protected]> * Remove explicit Jackson from sdk-tests module. Signed-off-by: Artur Ciocanu <[email protected]> * Make sure <scope>test</scope> is used for test dependencies. Signed-off-by: Artur Ciocanu <[email protected]> * Remove extra Jackson modules. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
salaboy
force-pushed
the
1569-save-metadata
branch
from
47b855c to
c7f2aea
Compare
artur-ciocanu
approved these changes
Oct 24, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1570 +/- ##
============================================
+ Coverage 76.91% 78.49% +1.57%
- Complexity 1592 1931 +339
============================================
Files 145 216 +71
Lines 4843 5868 +1025
Branches 562 658 +96
============================================
+ Hits 3725 4606 +881
- Misses 821 924 +103
- Partials 297 338 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new method signature to support metadata map, I've added a test that validates that the custom metadata is added.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1569
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: