Fix: Add DAPR_RUNTIME_HOST env variable support #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: getDefaultHttpPort() already respected DAPR_HTTP_PORT however, settings.getDefaultHost() did not use DAPR_RUNTIME_HOST Solution: (closes Custom sidecar port Fixes dapr#646) -Added DAPR_RUNTIME_HOST env variable support to Settings.getDefaultHost() Now users can set both DAPR_RUNTIME_HOST and DAPR_HTTP_PORT to fully control where client connects Tests: Created new dedicated test file for env mutations, so as to not mix up jest.isolateModules and top level Settings import Signed-off-by: mnothman <[email protected]>
Signed-off-by: mnothman <[email protected]>
mnothman
force-pushed
the
fix-issue-646
branch
from
3d2464e to
41498a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Settings.getDefaultHost()was hardcoded to return"127.0.0.1", ignoring theDAPR_RUNTIME_HOSTenvironment variable. This meant users couldn't configure the client host via environment variables when running Dapr with custom ports.Solution: Added support for the
DAPR_RUNTIME_HOSTenvironment variable inSettings.getDefaultHost():Now users can configure both host and port via environment variables when Dapr CLI sets them automatically.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #646
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: