Skip to content

Conversation

siri-varma
Copy link
Contributor

@siri-varma siri-varma commented May 27, 2025

Description

Add quickstart for Conversation AI sdk

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1155

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: siri-varma <[email protected]>
@siri-varma siri-varma requested review from a team as code owners May 27, 2025 19:33
@siri-varma
Copy link
Contributor Author

@salaboy @cicoyle @artur-ciocanu Can you folks take a look at this PR please ?

cicoyle
cicoyle previously approved these changes May 27, 2025
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
@siri-varma
Copy link
Contributor Author

@cicoyle Could you please approve the CI one more time ? I validated it locally. Should succeed now.

siri-varma and others added 3 commits May 27, 2025 18:52
@salaboy
Copy link
Contributor

salaboy commented May 28, 2025

@siri-varma same.. from a pure Java standpoint this PR LGTM, ready to be merged!

Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @siri-varma a couple changes :)

Co-authored-by: Alice Gibbons <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
@alicejgibbons alicejgibbons added the do-not-merge Do not merge the PR label May 28, 2025
Signed-off-by: siri-varma <[email protected]>
@siri-varma
Copy link
Contributor Author

image

Validated locally

@siri-varma
Copy link
Contributor Author

@alicejgibbons small request, could you please trigger the build for this PR ? Want to make sure it passes so that we will not have any surprises at the end

@cicoyle
Copy link
Contributor

cicoyle commented Jun 24, 2025

Im honestly fine merging this and then once I cut the official java release we can come back and update the versions everywhere - that way this PR doesnt get blocked

@siri-varma
Copy link
Contributor Author

@alicejgibbons Do you think we can go ahead and merge this PR now ? I will update the sdks to the latest version once 1.15 is out

@alicejgibbons
Copy link
Contributor

@siri-varma we want to align this PR with the 1.16 conversation changes so will pull those in when we get a 1.16.0 RC 2

@alicejgibbons
Copy link
Contributor

alicejgibbons commented Aug 7, 2025

Need to add tool calling to this quickstart for 1.16 as described here: #1213 and retarget 1.16 branch

@alicejgibbons
Copy link
Contributor

Same with this one - if you do the retargeting to 1.16 branch then im happy to add the tool calling bits after your merge!

@siri-varma siri-varma changed the base branch from master to release-1.16 August 18, 2025 04:37
@siri-varma
Copy link
Contributor Author

@alicejgibbons Its done

@alicejgibbons alicejgibbons removed the do-not-merge Do not merge the PR label Aug 20, 2025
Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating pom dep

java sdk 1.15.0

Signed-off-by: Alice Gibbons <[email protected]>
@alicejgibbons
Copy link
Contributor

Merging this one since the csharp quickstart is failing due to #1212

@alicejgibbons alicejgibbons merged commit 5b87573 into dapr:release-1.16 Aug 20, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java SDK Conversation API quickstart
5 participants