-
Notifications
You must be signed in to change notification settings - Fork 547
Add quickstart for Conversation AI java sdk #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quickstart for Conversation AI java sdk #1196
Conversation
Signed-off-by: siri-varma <[email protected]>
@salaboy @cicoyle @artur-ciocanu Can you folks take a look at this PR please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
@cicoyle Could you please approve the CI one more time ? I validated it locally. Should succeed now. |
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
@siri-varma same.. from a pure Java standpoint this PR LGTM, ready to be merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @siri-varma a couple changes :)
conversation/java/sdk/conversation/src/main/java/com/service/ConversationAIApplication.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Alice Gibbons <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: siri-varma <[email protected]>
…-varma/quickstarts into users/svegiraju/quickstarts
conversation/java/sdk/conversation/src/main/java/com/service/ConversationAIApplication.java
Outdated
Show resolved
Hide resolved
conversation/java/sdk/conversation/src/main/java/com/service/ConversationAIApplication.java
Outdated
Show resolved
Hide resolved
Signed-off-by: siri-varma <[email protected]>
@alicejgibbons small request, could you please trigger the build for this PR ? Want to make sure it passes so that we will not have any surprises at the end |
Im honestly fine merging this and then once I cut the official java release we can come back and update the versions everywhere - that way this PR doesnt get blocked |
@alicejgibbons Do you think we can go ahead and merge this PR now ? I will update the sdks to the latest version once 1.15 is out |
@siri-varma we want to align this PR with the 1.16 conversation changes so will pull those in when we get a 1.16.0 RC 2 |
Need to add tool calling to this quickstart for 1.16 as described here: #1213 and retarget 1.16 branch |
Same with this one - if you do the retargeting to 1.16 branch then im happy to add the tool calling bits after your merge! |
@alicejgibbons Its done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating pom dep
java sdk 1.15.0 Signed-off-by: Alice Gibbons <[email protected]>
Merging this one since the csharp quickstart is failing due to #1212 |
Description
Add quickstart for Conversation AI sdk
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1155
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: