fix(caddy): move ResetRegisteredStorages from Start to Stop#729
Open
everyx wants to merge 1 commit intodarkweak:masterfrom
Open
fix(caddy): move ResetRegisteredStorages from Start to Stop#729everyx wants to merge 1 commit intodarkweak:masterfrom
everyx wants to merge 1 commit intodarkweak:masterfrom
Conversation
Move the storage cleanup to Stop() so that: 1. Initial startup works correctly (middleware registers storers first) 2. Reload properly cleans up old storage connections Previously ResetRegisteredStorages was called in Start(), which cleared the storages that were just registered by middleware during Provision. Relates: darkweak#723
✅ Deploy Preview for teal-sprinkles-4c7f14 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the storage cleanup to Stop() so that:
Previously ResetRegisteredStorages was called in Start(), which cleared the storages that were just registered by middleware during Provision.
Relates: #723