[compliance] Update goldens - 7 fewer failures!#526
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the compliance and smuggling test reports for the shelf package, marking several previously failing or warning test cases as passing. These improvements cover areas such as Transfer-Encoding handling and request smuggling prevention. The shelf_summary.md file has been updated to reflect the improved test results, showing an increase in passing tests. I have no feedback to provide.
Member
Author
|
Waiting for the fix in Specifically #525 |
athomas
approved these changes
May 5, 2026
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 5, 2026
Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/7270c43..9c96bfe): 9c96bfe Mon May 4 09:35:46 2026 -0700 Jacob MacDonald Add test for DTD discovery (dart-lang/ai#465) af7e829 Mon May 4 08:36:10 2026 -0700 Jacob MacDonald Add test for DTD discovery (dart-lang/ai#465) f151df9 Fri May 1 07:54:12 2026 -0700 dependabot[bot] Bump actions/cache from 5.0.4 to 5.0.5 in the github-actions group (dart-lang/ai#464) 03d251c Thu Apr 30 12:34:59 2026 -0700 Jacob MacDonald add obsolete issues skill (dart-lang/ai#462) dartdoc (https://github.com/dart-lang/dartdoc/compare/2e30b8e..77a52b6): 77a52b61 Tue May 5 19:38:04 2026 +0200 dependabot[bot] Bump analyzer from 12.1.0 to 13.0.0 (dart-lang/dartdoc#4242) 4fa2b5dd Fri May 1 22:21:16 2026 +0000 dependabot[bot] Bump the github-actions group with 3 updates (dart-lang/dartdoc#4241) ecosystem (https://github.com/dart-lang/ecosystem/compare/ed4e053..319ff81): 319ff81 Fri May 1 21:48:23 2026 +0000 dependabot[bot] Bump the github-actions group with 3 updates (dart-lang/ecosystem#414) http (https://github.com/dart-lang/http/compare/2c84f24..c140dc0): c140dc0 Mon May 4 13:22:37 2026 -0700 Brian Quinlan feat(cronet_http): decode cronet exceptions (dart-lang/http#1912) 057c768 Fri May 1 03:44:57 2026 +0000 dependabot[bot] chore(deps): bump the github-actions group with 2 updates (dart-lang/http#1914) shelf (https://github.com/dart-lang/shelf/compare/cc6b57d..74d58bc): 74d58bc Tue May 5 01:52:47 2026 -0700 Kevin Moore [compliance] Update goldens - 7 fewer failures! (dart-lang/shelf#526) c6b3f75 Mon May 4 12:27:31 2026 -0700 dependabot[bot] Bump actions/cache in the github-actions group across 1 directory (dart-lang/shelf#524) 498d45e Mon May 4 12:14:02 2026 -0700 Kevin Moore test: make compliance golden tests "thoughtful" and clean up state (dart-lang/shelf#525) test (https://github.com/dart-lang/test/compare/d5da922..14f99ec): 14f99ecd Fri May 1 16:18:32 2026 -0700 Nate Bosch Track the OS for browser platforms (dart-lang/test#2449) fd2b4be6 Fri May 1 16:08:03 2026 -0700 Nate Bosch Override test packages in coverage tests (dart-lang/test#2638) a1b82f18 Fri May 1 04:03:25 2026 +0000 dependabot[bot] Bump the github-actions group with 3 updates (dart-lang/test#2637) tools (https://github.com/dart-lang/tools/compare/c0dc794..6a7dd15): 6a7dd157 Tue May 5 09:41:25 2026 -0700 Jacob MacDonald support initial selection for multiselect, as well as select/unselect all (dart-lang/tools#2399) 1a026068 Fri May 1 06:11:14 2026 +0000 dependabot[bot] Bump actions/upload-pages-artifact from 4 to 5 in the github-actions group (dart-lang/tools#2392) web (https://github.com/dart-lang/web/compare/7c908b1..294391c): 294391c Mon May 4 09:59:58 2026 -0700 Kevin Moore [chore] Sort the members in elements.dart (dart-lang/web#544) 41c4049 Mon May 4 09:35:13 2026 -0700 Kevin Moore refactor: move most of the AST elements to their own file (dart-lang/web#543) webdev (https://github.com/dart-lang/webdev/compare/d33d270..f9a5660): f9a56607 Fri May 1 14:48:09 2026 -0700 MarkZ Splitting additional DWDS and Webdev tests between amd and ddc module systems (dart-lang/webdev#2828) b2cd91f6 Thu Apr 30 13:02:04 2026 -0700 Nicholas Shahan [dwds] Prepare to publish 27.1.1 (dart-lang/webdev#2825) Change-Id: Ifa3631598d554132a3f457a0e5d9e02089e5ce32 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/500980 Auto-Submit: Nate Bosch <nbosch@google.com> Reviewed-by: Brian Quinlan <bquinlan@google.com> Commit-Queue: Brian Quinlan <bquinlan@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.