feat: add configurable rateDenominator to estimateIncidence#26
Open
merqurio wants to merge 9 commits into
Open
feat: add configurable rateDenominator to estimateIncidence#26merqurio wants to merge 9 commits into
merqurio wants to merge 9 commits into
Conversation
Author
|
Hey @edward-burn , let me know if there's something else I should do, I see all the tests passing. |
merqurio
force-pushed
the
main
branch
2 times, most recently
from
f063b68 to
11cab4c
Compare
- Add rateDenominator parameter to estimateIncidence (default 100,000). - Update incidence calculation and CI estimation to support custom denominators. - Dynamically name incidence columns (e.g. incidence_1000_pys) based on the denominator. - Update tableIncidence, plotIncidence, and related plotting functions to support dynamic column names. - Add tests for custom rate denominators.
Collaborator
|
Hi @merqurio unfortunately I cant accept contrributions to darwin eu packages from external contributors https://github.com/darwin-eu/IncidencePrevalence?tab=contributing-ov-file I'm not so opposed to adding an additional parameter like this (but with the need to balance against desire to keep number of arguments down to a manageable amount). So, if it's OK, could you open an issue with this as a feature request and I can see what I can do |
- Add `plotRollingIncidence()` mapped to window_start_days - Add `asRollingIncidenceResult()` for tidying objects - Fix interval coercion bug in `tidyResult()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
incidence_1000_pys) based on the denominator.