-
Notifications
You must be signed in to change notification settings - Fork 44
chore(release): update changelog and version to 2.1.0 #2820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughConsolidates CHANGELOG entries into a final 2.1.0 release, bumps many package and Cargo manifest versions from 2.1.0-rc.1 (and pre-release variants) to 2.1.0, and adds a dashmate config migration for 2.1.0 that standardizes specific Docker image references. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant CLI as Release Script / CLI
participant Repo as Monorepo Files
participant Migrator as dashmate Migration
CLI->>Repo: Apply version bumps (package.json/Cargo.toml)
CLI->>Repo: Update CHANGELOG.md -> consolidate 2.1.0
Note over Migrator,Repo: New migration added for 2.1.0
CLI->>Migrator: Register migration for version 2.1.0
Migrator->>Repo: Modify dashmate config entries\n(set docker.image fields)
Repo-->>CLI: Commit changes (manifests, changelog, migration)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ gRPC Query Coverage Report |
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "1e0600cacc84655b479872346d2cac9db1f0d5ec4de78ede73c76a78e3752b1b"
)Xcode manual integration:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (5)
packages/dashmate/configs/getConfigFileMigrationsFactory.js (1)
1224-1224: Consider defensive access for rsDapi.The code directly accesses
options.platform.dapi.rsDapi.docker.imagewithout checking ifrsDapiexists. WhilersDapishould exist by this migration version (added in'2.1.0-dev.9'), defensive programming as seen in the'2.1.0-pr.2716.1'migration (lines 1193-1197) could prevent potential runtime errors during edge-case upgrades.If you want to add defensive checks:
'2.1.0': (configFile) => { Object.entries(configFile.configs) .forEach(([, options]) => { options.platform.drive.abci.docker.image = 'dashpay/drive:2'; options.platform.dapi.api.docker.image = 'dashpay/dapi:2'; - options.platform.dapi.rsDapi.docker.image = 'dashpay/rs-dapi:2'; + if (options.platform.dapi.rsDapi) { + options.platform.dapi.rsDapi.docker.image = 'dashpay/rs-dapi:2'; + } }); return configFile; },CHANGELOG.md (4)
1-1: Avoid markdownlint MD024 failures for repeated headings in changelogsChangelogs intentionally repeat section headings (e.g., Features, Bug Fixes) across versions. Suppress MD024 at file scope to keep CI green.
Apply this at the very top:
+<!-- markdownlint-disable MD024 --> ## [2.1.0](https://github.com/dashpay/platform/compare/v2.1.0-rc.1...v2.1.0) (2025-10-24)
99-101: Typo: dont → don'tMinor copyedit in CI section.
-* dont do CI when it's not needed ([#2774](https://github.com/dashpay/platform/issues/2774)) +* don't do CI when it's not needed ([#2774](https://github.com/dashpay/platform/issues/2774))
51-52: Use consistent “GroveDB” casingEarlier entries prefer “GroveDB”. Align for consistency.
-* update to groveDB 3.1 ([#2808](https://github.com/dashpay/platform/issues/2808)) +* update to GroveDB 3.1 ([#2808](https://github.com/dashpay/platform/issues/2808))
49-66: Consider adding a note about the dashmate config migration introduced in this PRAI summary mentions a new dashmate migration to standardize Docker image references. If present, add a short bullet under “Miscellaneous Chores” or “Build System” in 2.1.0 so operators notice it.
Would you like me to draft the exact entry text once we confirm the migration path and scope?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(7 hunks)packages/dashmate/configs/getConfigFileMigrationsFactory.js(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
packages/**/**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
packages/**/**/*.{js,ts,jsx,tsx}: Adhere to ESLint with Airbnb/TypeScript configs for JS/TS code
Use camelCase for JS/TS variables and functions
Use PascalCase for JS/TS classes
Prefer kebab-case filenames within JS packages
Files:
packages/dashmate/configs/getConfigFileMigrationsFactory.js
🧠 Learnings (1)
📓 Common learnings
Learnt from: QuantumExplorer
PR: dashpay/platform#2257
File: packages/rs-drive-abci/src/mimic/test_quorum.rs:159-164
Timestamp: 2024-11-20T16:16:01.830Z
Learning: QuantumExplorer prefers not to receive auto-generated messages asking to post on social media.
🪛 markdownlint-cli2 (0.18.1)
CHANGELOG.md
339-339: Multiple headings with the same content
(MD024, no-duplicate-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (134)
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (dapi-grpc) / Detect immutable structure changes
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (dapi-grpc) / Detect immutable structure changes
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (dapi-grpc) / Detect immutable structure changes
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Rust packages (dapi-grpc) / Detect immutable structure changes
- GitHub Check: Rust packages (dapi-grpc) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Formatting
- GitHub Check: Rust packages (rs-sdk-ffi) / Tests
- GitHub Check: Rust packages (dapi-grpc) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Unused dependencies
- GitHub Check: Rust packages (rs-sdk-ffi) / Linting
- GitHub Check: Rust packages (dpp) / Check each feature
- GitHub Check: Rust packages (dpp) / Linting
- GitHub Check: Rust packages (dpns-contract) / Unused dependencies
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (RS-DAPI, rs-dapi, rs-dapi) / Build RS-DAPI image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
🔇 Additional comments (2)
packages/dashmate/configs/getConfigFileMigrationsFactory.js (1)
1219-1228: Verify if tenderdash image should be updated.The previous
'2.1.0-rc.1'migration (line 1214) updatesplatform.drive.tenderdash.docker.imageto'dashpay/tenderdash:1.5', but this'2.1.0'final release migration does not include the tenderdash image update. Please confirm whether:
- This is intentional (tenderdash should remain at 1.5 set by RC.1)
- The tenderdash image should be explicitly set here for the final release
If tenderdash should be at a specific version for the 2.1.0 release, apply this diff:
'2.1.0': (configFile) => { Object.entries(configFile.configs) .forEach(([, options]) => { options.platform.drive.abci.docker.image = 'dashpay/drive:2'; options.platform.dapi.api.docker.image = 'dashpay/dapi:2'; options.platform.dapi.rsDapi.docker.image = 'dashpay/rs-dapi:2'; + options.platform.drive.tenderdash.docker.image = 'dashpay/tenderdash:1.5'; }); return configFile; },CHANGELOG.md (1)
21-26: Fix broken list rendering in Features (missing list markers)Three items render as plain paragraphs; add bullets for consistent formatting.
-* add tests for new token transitions -* evo sdk ([#2771](https://github.com/dashpay/platform/issues/2771)) +* add tests for new token transitions +* evo sdk ([#2771](https://github.com/dashpay/platform/issues/2771)) ... -* **wasm-sdk:** implement four missing token transitions +* **wasm-sdk:** implement four missing token transitionsLikely an incorrect or invalid review comment.
| * **platform:** creator id and improved verification of document uniqueness before insertion (#2790) | ||
| * **wasm-sdk:** handle identity create transition signing for all types of keys (#2754) | ||
| * **wasm-sdk:** remove unused key_id parameters from state transitions (#2759) | ||
| * **sdk:** provide all getStatus info (#2729) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normalize issue links and spacing in Breaking Changes
Make issue references clickable and remove the stray double space for consistency.
-* **platform:** creator id and improved verification of document uniqueness before insertion (#2790)
-* **wasm-sdk:** handle identity create transition signing for all types of keys (#2754)
-* **wasm-sdk:** remove unused key_id parameters from state transitions (#2759)
-* **sdk:** provide all getStatus info (#2729)
+* **platform:** creator id and improved verification of document uniqueness before insertion ([#2790](https://github.com/dashpay/platform/issues/2790))
+* **wasm-sdk:** handle identity create transition signing for all types of keys ([#2754](https://github.com/dashpay/platform/issues/2754))
+* **wasm-sdk:** remove unused `key_id` parameters from state transitions ([#2759](https://github.com/dashpay/platform/issues/2759))
+* **sdk:** provide all getStatus info ([#2729](https://github.com/dashpay/platform/issues/2729))🤖 Prompt for AI Agents
CHANGELOG.md lines 6-9: the issue references like "(#2790)" should be converted
to clickable Markdown issue links and the stray double space after the
"wasm-sdk:" label should be removed for consistent formatting; update each
"(#NNNN)" to "([#NNNN](https://github.com/<org>/<repo>/issues/NNNN))" (replace
<org>/<repo> with the actual repo path used in the project) and remove the extra
space after "wasm-sdk:" so the line reads "* **wasm-sdk:** handle identity..."
with single spacing.
Summary by CodeRabbit