Skip to content

Experimental: Use kr8s for API calls in controller #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Experimental: Use kr8s for API calls in controller #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
570f578
Release 2023.3.2
jacobtomlinson Mar 30, 2023
7b1eb0f
Experimental: Use kr8s for API calls in controller
jacobtomlinson Apr 6, 2023
9a0544f
Set KUBECONFIG in contetx manager
jacobtomlinson Apr 6, 2023
cf1932c
Bump kr8s to 0.3.0
jacobtomlinson May 5, 2023
effd5ca
Don't create API object at root level
jacobtomlinson May 5, 2023
13879de
Merge branch 'main' of github.com:dask/dask-kubernetes into kr8s-spike
jacobtomlinson May 19, 2023
4f14630
Bump syntax to kr8s 0.4.0
jacobtomlinson May 19, 2023
ada3e61
More migration changes
jacobtomlinson May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions dask_kubernetes/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import pytest

import contextlib
import pathlib
import os
import subprocess
Expand All @@ -17,6 +18,30 @@
check_dependency("docker")


@contextlib.contextmanager
def set_env(**environ):
"""
Temporarily set the process environment variables.

>>> with set_env(PLUGINS_DIR=u'test/plugins'):
... "PLUGINS_DIR" in os.environ
True

>>> "PLUGINS_DIR" in os.environ
False

:type environ: dict[str, unicode]
:param environ: Environment variables to set
"""
old_environ = dict(os.environ)
os.environ.update(environ)
try:
yield
finally:
os.environ.clear()
os.environ.update(old_environ)


@pytest.fixture()
def kopf_runner(k8s_cluster):
yield KopfRunner(["run", "-m", "dask_kubernetes.operator", "--verbose"])
Expand All @@ -40,10 +65,9 @@ def k8s_cluster(request, docker_image):
image=image,
)
kind_cluster.create()
os.environ["KUBECONFIG"] = str(kind_cluster.kubeconfig_path)
kind_cluster.load_docker_image(docker_image)
yield kind_cluster
del os.environ["KUBECONFIG"]
with set_env(KUBECONFIG=str(kind_cluster.kubeconfig_path)):
yield kind_cluster
if not request.config.getoption("keep_cluster"):
kind_cluster.delete()

Expand Down
Loading