hist(group): add validation & empty-data handling; docstring, guide and tests #658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Table.histneeded clearer documentation and safer behavior for thegroupargument.Changes
Code
datascience/tables.py:histgroupis a legal column (label or index); otherwise raiseValueErrorwith a clear message.groupcannot be used withbin_column; and grouping allows only one numeric data column.t.hist('height', group='gender')t.hist('height', group='gender', side_by_side=True)Docs
docs/hist_grouping.md:.rstand add it to the TOC.)Tests
tests/test_hist_group.pyValueError.(Optional) Maps small fixes
datascience/maps.pyattrsupplied (Folium >= 0.20).text_color->textColoroption forBeautifyIconfor backward compatibility.Verification
Files changed (for quick review)
datascience/tables.py[around lines ~5310, ~5398, ~5420, ~5455]docs/hist_grouping.mdtests/test_hist_group.pydatascience/maps.pyCompatibility & Notes