Fix: Allow custom client to be passed to ChatDatabricks (Issue #128) #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses issue #128 by modifying the
__init__
method of theChatDatabricks
class to allow a custom client to be passed in via the constructor.Previously, any client passed in the constructor would be overwritten by the default client. With this change:
client
is provided inkwargs
, that client instance is used.get_deployment_client(self.target_uri)
.A new unit test,
test_chat_model_with_custom_client
, has been added tointegrations/langchain/tests/unit_tests/test_chat_models.py
to verify this functionality. The test ensures that the provided custom client is correctly assigned and its methods are called when theChatDatabricks
instance makes predictions.