UDF checkpoints for aggregator #1470
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
dreadatour
reviewed
Nov 20, 2025
| self.setup() | ||
|
|
||
| # Check if partition_id is available (when partition_by is used) | ||
| partition_id_idx = None |
Contributor
There was a problem hiding this comment.
Suggested change
| partition_id_idx = None | |
| partition_id_idx: int | None = None |
dreadatour
reviewed
Nov 20, 2025
| ) | ||
| # Include sys__input_id to track which partition produced each output | ||
| output = [ | ||
| {"sys__input_id": input_id} |
Contributor
There was a problem hiding this comment.
Do we want to add sys__input_id as constant (same way we added from datachain.data_storage.schema import PARTITION_COLUMN_ID)?
dreadatour
reviewed
Nov 20, 2025
Comment on lines
+645
to
+649
| Create table with partition mappings (sys__id -> partition_id). | ||
| Args: | ||
| query: Input query with sys__id column | ||
| table_name: Name for the partition table. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing UDF checkpoints for aggregator.