Fix nested column flattening in group_by to use underscores #1503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early attempt to fix #1329
I'm not very familiar with the code but with my knowledge and the help of some LLM I managed to put together this solution. I'm aware that this could be quite disruptive for users as it's changing the output of some well established function such as
to_list(see the example in this test). People more knowledgeable of the use cases can judge this.If we want to preserve the
nested.level1.namestructure, I feel that the options go through:to_pandasmethod and more precisely thisget_headers_with_lengthfolk (source) which is responsible of getting the columns that then become a multi-index.Let me know what you think
(There are a couple of lint errors that we can address once a consensus on the approach is reached)