Skip to content

Lock torchcodec dependency to version <0.10.0 #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dreadatour wants to merge 2 commits into from
Closed

Lock torchcodec dependency to version <0.10.0 #1570

dreadatour wants to merge 2 commits into from

Conversation

@dreadatour
Copy link
Contributor

@dreadatour dreadatour commented Jan 23, 2026

torchcodec version 0.10.0 was released Jan 22, 2026. SaaS tests are now failing. Lock dependency until fix.

@dreadatour dreadatour requested review from a team, Copilot and shcheklein January 23, 2026 20:07
@dreadatour dreadatour self-assigned this Jan 23, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 23, 2026 •
edited
Loading

Deploying datachain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7231b79
Status: ✅  Deploy successful!
Preview URL: https://be331c7e.datachain-2g6.pages.dev
Branch Preview URL: https://fix-test-hf-audio.datachain-2g6.pages.dev

View logs

@shcheklein
Copy link
Contributor

shcheklein commented Jan 23, 2026

Alternative #1571

Ideally it should be this way ^^. Have you tried it?

Copilot AI reviewed Jan 23, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR locks the torchcodec dependency to versions below 0.10.0 to address compatibility issues causing SaaS test failures. The torchcodec 0.10.0 release on January 22, 2026 introduced breaking changes that affect the test_hf_audio functionality.

Changes:

  • Added version constraint torchcodec<0.10.0 to the hf optional dependencies group in pyproject.toml

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dreadatour
Copy link
Contributor Author

dreadatour commented Jan 23, 2026

Alternative #1571

Ideally it should be this way ^^. Have you tried it?

Hm... Trying 👍

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dreadatour dreadatour requested a review from Copilot January 23, 2026 20:19
Copilot AI reviewed Jan 23, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dreadatour dreadatour closed this Jan 24, 2026
@dreadatour dreadatour deleted the fix-test-hf-audio branch January 24, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@shcheklein shcheklein Awaiting requested review from shcheklein

Assignees

@dreadatour dreadatour

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dreadatour @shcheklein