feat: Add suport for list/get/run/stop task#153
Open
vimsucks wants to merge 1 commit intodatadrivers:mainfrom
Open
feat: Add suport for list/get/run/stop task#153vimsucks wants to merge 1 commit intodatadrivers:mainfrom
vimsucks wants to merge 1 commit intodatadrivers:mainfrom
Conversation
anmoel
reviewed
Mar 13, 2025
| ID string `json:"id"` | ||
| Name string `json:"name"` | ||
| Type string `json:"type"` | ||
| Message *string `json:"message"` |
Member
There was a problem hiding this comment.
Suggested change
| Message *string `json:"message"` | |
| Message *string `json:"message,omitempty"` |
anmoel
reviewed
Mar 13, 2025
| Type string `json:"type"` | ||
| Message *string `json:"message"` | ||
| CurrentState string `json:"currentState` | ||
| LastRunResult *string `json:"lastRunResult` |
Member
There was a problem hiding this comment.
Suggested change
| LastRunResult *string `json:"lastRunResult` | |
| LastRunResult *string `json:"lastRunResult,omitempty"` |
anmoel
reviewed
Mar 13, 2025
| Message *string `json:"message"` | ||
| CurrentState string `json:"currentState` | ||
| LastRunResult *string `json:"lastRunResult` | ||
| NextRun *string `json:"nextRun"` |
Member
There was a problem hiding this comment.
Suggested change
| NextRun *string `json:"nextRun"` | |
| NextRun *string `json:"nextRun,omitempty"` |
anmoel
reviewed
Mar 13, 2025
| CurrentState string `json:"currentState` | ||
| LastRunResult *string `json:"lastRunResult` | ||
| NextRun *string `json:"nextRun"` | ||
| LastRun *string `json:"lastRun"` |
Member
There was a problem hiding this comment.
Suggested change
| LastRun *string `json:"lastRun"` | |
| LastRun *string `json:"lastRun,omitempty"` |
anmoel
requested changes
Mar 13, 2025
|
|
||
| type PaginationResult[T any] struct { | ||
| Items []T `json:"items"` | ||
| ContinuationToken *string `json:"continuationToken"` |
Member
There was a problem hiding this comment.
Suggested change
| ContinuationToken *string `json:"continuationToken"` | |
| ContinuationToken *string `json:"continuationToken,omitempty"` |
| if len(tasks) > 0 { | ||
| task, err := s.GetTask(tasks[0].ID) | ||
| if err != nil { | ||
| assert.Failf(t, "fail to run task", err.Error()) |
Member
There was a problem hiding this comment.
why fail tu run task? you onle get the task and don't run them
Member
|
pleas test run and stop functions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://help.sonatype.com/en/tasks-api.html