Repository navigation
fix: forward physical optimizer context through tracing wrappers - #69
Open
alexanderbianchi wants to merge 1 commit into
Open
alexanderbianchi wants to merge 1 commit into
alexanderbianchi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Physical optimizer tracing wrappers currently inherit the default
optimize_with_context, which reduces the context toConfigOptionsand callsoptimize. This loses access to a session's registeredStatisticsRegistry. For example,JoinSelectioncan then fall back to built-in statistics providers even though a custom registry was configured.Forward
optimize_with_contextthrough both the phase-only error-cleanup wrapper and the full instrumentation wrapper. Share each wrapper's handling between entry points so legacyoptimizecalls retain their behavior, and context-aware calls retain tracing, plan-diff detection, and error cleanup.Tests
Four new regressions exercise the public instrumentation macro and query execution in phase-only/full modes:
All four fail on the unpatched base. Existing config-only physical optimizer error tests remain in place.
Validation:
cargo test --locked --workspace --all-targetscargo test --locked --workspace --doc./ci/scripts/rust_clippy.sh./ci/scripts/rust_docs.shcargo fmt --all -- --check