Remove deprecated TPC-H CLI flags - #421
Open
kevinjqliu wants to merge 5 commits into
Open
Conversation
Remove the retired compatibility flags and migrate the shared Parquet writer off its deprecated column-writer API. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Restore the existing deprecated writer API so this branch remains focused on removing retired CLI flags. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
doing some cleanup work, we released v3.0.0 with these commands showing deprecation warning. We can fully remove these for the next v4 release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the TPC-H flags deprecated in #173.
Output format selection moved from
--formatto dedicated subcommands:--format=parquet→tpchgen-cli parquet--format=csv→tpchgen-cli csv--format=tbl→tpchgen-cli tbl(or omit the subcommand)Parquet-specific options moved from top-level flags to the
parquetsubcommand:--parquet-compression=ZSTD(1)→tpchgen-cli parquet --compression=ZSTD(1)--parquet-row-group-bytes=1000000→tpchgen-cli parquet --row-group-bytes=1000000Tested with
cargo test -p tpcgen-cli --all-featuresand Clippy.