Skip to content

feat(connectors): BI-6608 YDB Array support - #1281

Closed
catsona wants to merge 37 commits into
mainfrom
catsona/bi-6608/ydb_array
Closed

feat(connectors): BI-6608 YDB Array support#1281
catsona wants to merge 37 commits into
mainfrom
catsona/bi-6608/ydb_array

Conversation

@catsona

@catsona catsona commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@catsona
catsona force-pushed the catsona/bi-6611/ydb_db_cast branch from e843d79 to f7b7ddc Compare November 27, 2025 12:34
@catsona
catsona force-pushed the catsona/bi-6608/ydb_array branch 3 times, most recently from c254921 to 50497be Compare November 27, 2025 16:57
@catsona
catsona marked this pull request as ready for review November 27, 2025 20:39
@catsona
catsona force-pushed the catsona/bi-6608/ydb_array branch from 50497be to 1350212 Compare November 28, 2025 11:58
@ovsds
ovsds requested a review from Copilot December 10, 2025 08:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for YDB array operations by implementing array functions, type handling, and compilation logic for the YQL dialect.

  • Implements array types (List) with optional item support in the dialect layer
  • Adds lambda/closure compilation and tuple access operations for complex array manipulations
  • Implements comprehensive array function definitions (ARRAY, CONTAINS, SLICE, REPLACE, etc.)

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
lib/dl_sqlalchemy_ydb/dl_sqlalchemy_ydb/dialect.py Adds YqlListType, YqlClosure, YqlDotAccess classes and custom compiler methods for array/lambda support
lib/dl_connector_ydb/docker-compose/Dockerfile.db-ydb Updates YDB Docker image reference to use digest-based image from ydbplatform
lib/dl_connector_ydb/dl_connector_ydb_tests/db/formula/test_functions_array.py Adds array function tests with view-based test setup for YDB
lib/dl_connector_ydb/dl_connector_ydb_tests/db/formula/base.py Adds YQLDbEvaluator for handling bytes-to-string conversion in test results
lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/functions_type.py Adds List type specifications for Double, Int64, and String with optional item support
lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/functions_array.py Implements all array function definitions including ARRAY, CONTAINS, SLICE, REPLACE, etc.
lib/dl_connector_ydb/dl_connector_ydb/formula/definitions/all.py Imports and includes DEFINITIONS_ARRAY in the master definitions list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/dl_sqlalchemy_ydb/dl_sqlalchemy_ydb/dialect.py Outdated
Comment thread lib/dl_sqlalchemy_ydb/dl_sqlalchemy_ydb/dialect.py Outdated
Comment thread lib/dl_connector_ydb/dl_connector_ydb_tests/db/formula/test_functions_array.py Outdated
Comment thread lib/dl_connector_ydb/dl_connector_ydb_tests/db/formula/test_functions_array.py Outdated
@catsona
catsona force-pushed the catsona/bi-6608/ydb_array branch 15 times, most recently from e653f08 to 9bef6b1 Compare January 30, 2026 10:10
Base automatically changed from catsona/bi-6611/ydb_db_cast to main January 30, 2026 14:07
@catsona
catsona force-pushed the catsona/bi-6608/ydb_array branch from 9bef6b1 to 42351e6 Compare February 2, 2026 11:22
Comment thread lib/dl_sqlalchemy_ydb/dl_sqlalchemy_ydb/dialect.py
@catsona
catsona force-pushed the catsona/bi-6608/ydb_array branch from 42351e6 to f56c763 Compare April 3, 2026 14:41
@github-actions github-actions Bot added component/connectors Connectors type/feat New features labels Apr 3, 2026
Comment thread lib/dl_formula/dl_formula/definitions/functions_array.py Outdated
Comment thread lib/dl_sqlalchemy_ydb/dl_sqlalchemy_ydb/dialect.py Outdated
Comment thread lib/dl_connector_ydb/dl_connector_ydb/db_testing/engine_wrapper.py
@KonstantAnxiety
KonstantAnxiety deleted the catsona/bi-6608/ydb_array branch April 13, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/connectors Connectors type/feat New features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants