Stop-DbaService, Start-DbaService - Add PolyBase and Launchpad service type support #9879
+22
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e type support Fixes #9443 When Enable-DbaAgHadr is run with -Force on servers with PolyBase installed, the service restart would fail because Stop-DbaService and Start-DbaService did not recognize PolyBase and Launchpad as valid service types. Changes: - Stop-DbaService: Added PolyBase and Launchpad to ValidateSet for Type parameter - Stop-DbaService: Enhanced Force logic to automatically include PolyBase services when stopping Engine - Start-DbaService: Added PolyBase and Launchpad to ValidateSet for Type parameter - Update-ServiceStatus: Updated warning message to mention PolyBase dependencies - Updated help documentation in both functions to reflect new service types This brings Stop-DbaService and Start-DbaService in line with Get-DbaService and Restart-DbaService which already supported these service types. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Chrissy LeMaire <[email protected]>
|
LGTM but i don't have a local instance with polybase to do a quick test. |
|
same and same 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9443
This PR adds support for PolyBase and Launchpad service types to Stop-DbaService and Start-DbaService, fixing the issue where Enable-DbaAgHadr -Force would fail on servers with PolyBase installed.
Changes
This brings Stop-DbaService and Start-DbaService in line with Get-DbaService and Restart-DbaService which already supported these service types.
Test Plan
Generated with Claude Code