Copy-DbaDatabase - Fix SetSourceOffline to only run on successful copy #9880
+85
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only set source database offline when the copy operation succeeds. Previously, the source database would be set offline even if the restore failed due to insufficient disk space or other errors. Fixes #9546 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Chrissy LeMaire <[email protected]>
|
@claude pls add an integration test |
|
Claude finished @potatoqualitee's task —— View job Integration Test Added ✓Successfully added regression tests for the SetSourceOffline fix. Tasks Completed
Implementation DetailsAdded a new regression test context with two test cases in
The test follows dbatools conventions:
Changes PushedCommit:
--- | |
Add regression tests for issue #9546 to verify that the source database only goes offline when the copy operation succeeds, not when it fails. Test coverage: - Verify source remains online when copy fails (database already exists) - Verify source goes offline when copy succeeds Co-authored-by: Chrissy LeMaire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9546
Only set source database offline when the copy operation succeeds. Previously, the source database would be set offline even if the restore failed due to insufficient disk space or other errors.
Changes
$copyDatabaseStatus.Status -eq "Successful"before setting the source database offline🤖 Generated with Claude Code