Replace malloc and realloc with corresponding glibc function#2316
Merged
Conversation
Collaborator
|
No particular reason, mostly habit. I've tried to avoid it, must have missed these. |
Collaborator
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The entire codebase uses g_malloc and g_realloc, but rofi.c and ssh.c do not.
g_malloc terminates the program on allocation failure. malloc does not.
Is there a particular reason why malloc is used here instead of g_malloc?
If malloc should be used here, a NULL check should be added.
Solution:
Replace malloc/realloc with g_malloc/g_realloc in rofi.c and malloc with g_malloc0 in ssh.c.