Fix Windows compatibility issue #7
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
biberplus.tagger.tagger_utils, the functionbuild_variable_dictionariesdoes not run properly in Windows. This is because on line 21, the filenames are being parsed by splitting on'/':This code does not behave as intended on Windows, because Windows directories use
'\\'instead of'/'. Thus, thevariables_dictkey corresponding toconstants/suasive_verbs.txtis'constants\\suasive_verbs'instead of'suasive_verbs'. This causes several downstream errors, e.g. when runningbiberplus.tagger.tag_text.To fix this issue, this pull request parses the filenames using
pathlibinstead of splitting on'/', thus populatingvariables_dictcorrectly on all platforms.