Change JavaScript to TypeScript#10
Open
xiaoxiangmoe wants to merge 3 commits into
Open
Conversation
xiaoxiangmoe
force-pushed
the
master
branch
2 times, most recently
from
711c7a8 to
1d69b7e
Compare
Owner
|
Wow it is a lot of changes:) I am not ready to accept such a massive rewrite by one step. You are not only rewrite JS to TS (it is ok), but also change the build procedure, add additional dependencies and even editor settings. Most of this is not related to code. What if we will start by minimal steps? Just by adding a single .d.ts file for the start? It will make TS users happy without the revolutionary changes. |
Contributor
Author
|
ok，I'll open a pr soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #8