Facet Terms Grouping (Port from FF) - #718
Open
utku-ozturk wants to merge 5 commits into
Open
utku-ozturk wants to merge 5 commits into
utku-ozturk wants to merge 5 commits into
Conversation
Bianca-Morris
approved these changes
Jun 2, 2023
Bianca-Morris
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this; looks good. Tested this on local in a bunch of Item search pages and a few embedded search tables; seems like the changes aren't causing any issues (as expected). I'd wait until @willronchetti has an opportunity to double check the search edits to merge this, though. Maybe reach out to him directly; it's possible it's slipped by him.
Contributor
Author
|
@Bianca-Morris Thanks for the review. By the way, we have an ongoing update that we already had applied for FF, and we will push the commit into CGAP shortly after the tests end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/nwosFKMo
Please also refer to:
The update allows for a hierarchical display of terms grouped under a grouping term. It also enables searching and selection by group names and individual terms.
You must add the
group_by_fieldproperty in schema json to define grouping for a facet.(the code block and screenshot below are only for examples, not actually pushed into repo)