train: allow passing custom learning rate optimizer#305
Open
breznak wants to merge 1 commit intodbolya:masterfrom
Open
train: allow passing custom learning rate optimizer#305breznak wants to merge 1 commit intodbolya:masterfrom
breznak wants to merge 1 commit intodbolya:masterfrom
Conversation
breznak
commented
Jan 26, 2020
| def train(optimizer=None): | ||
| """ | ||
| @param optimizer: set custom optimizer, default (None) uses | ||
| `torch.optim.SGD(net.parameters(), lr=args.lr, momentum=args.momentum, weight_decay=args.decay)` |
Contributor
Author
There was a problem hiding this comment.
ideally, I'd set the optimizer=SGD(...) here already, but the "net" is not available
|
|
||
| # Warm up by linearly interpolating the learning rate from some smaller value | ||
| # Warm up by linearly interpolating the learning rate from some smaller value | ||
| if cfg.lr_warmup_until > 0 and iteration <= cfg.lr_warmup_until: |
Contributor
Author
There was a problem hiding this comment.
can we leave this fine tuning, lr management to the optimizer (or other code provided by the framework)?
Contributor
Author
|
Please feel free to take over this, I'll be out for the next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
train(optimizer=torch.optim.MyCustomOptimizer(..))For #298