Skip to content

Conversation

ttusing
Copy link
Contributor

@ttusing ttusing commented Aug 12, 2025

Resolves #11913

Problem

Sometimes, the lockfile is regenerated and this is not very visible to the user. This can cause package updates at unexpected times, leading to instability.

Solution

Add a warning when the lockfile is regenerated

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@ttusing ttusing requested a review from a team as a code owner August 12, 2025 04:14
Copy link

cla-bot bot commented Aug 12, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tobie Tusing.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Aug 12, 2025
@ttusing ttusing changed the title Add a warning when regenerating the lockfile for packages Add a warning when regenerating the lockfile for packages and there is a hash mismatch Aug 12, 2025
@ttusing
Copy link
Contributor Author

ttusing commented Aug 12, 2025

🤔 did the CLA check fail because I didn't sign the commit with my email address? Think so.

Can fix that once thats confirmed/PR is reviewed for being desirable change and also add the changie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Throw warning when package lockfile is regenerated
1 participant