Add test: semantic manifest unaffected by cache config#12589
Draft
theyostalservice wants to merge 2 commits intomainfrom
Draft
Add test: semantic manifest unaffected by cache config#12589theyostalservice wants to merge 2 commits intomainfrom
theyostalservice wants to merge 2 commits intomainfrom
Conversation
The cache.enabled field on SavedQueryConfig is a dbt-core-only concern that is intentionally excluded from the semantic manifest. This test verifies that the PydanticSavedQuery serialization (used by dbt-semantic-interfaces) produces identical output regardless of whether cache is enabled or disabled, ensuring downstream consumers of the semantic manifest are never impacted by cache config changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Capture the baseline cache.enabled value and explicitly assert it flipped before comparing the semantic manifest outputs, making the test a proper control-vs-experiment comparison. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12589 +/- ##
==========================================
+ Coverage 91.40% 91.42% +0.02%
==========================================
Files 203 203
Lines 25574 25574
==========================================
+ Hits 23376 23382 +6
+ Misses 2198 2192 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestSemanticManifestUnaffectedByCacheConfig) that proves the semantic manifest output is identical regardless ofcache.enabledstatus on saved queriescacheconfig is a dbt-core-only concern stored inSavedQueryConfig; it is intentionally excluded from the semantic manifest becausePydanticSavedQuery(fromdbt-semantic-interfaces) does not define aconfigfieldTest plan
enabled=False), builds semantic manifest, then re-parses with cache enabled via project config and rebuilds — asserts both outputs are identicalconfignorcachekeys appear in the serialized semantic manifest saved query dictpytest tests/functional/saved_queries/test_configs.py::TestSemanticManifestUnaffectedByCacheConfig -v🤖 Generated with Claude Code