fix: raise correct deprecation when config key is top-level in generic test (#12572)

[kalluripradeep]

Problem

Fixes #12572
Parent: #12394

When a user defines a config property like where at the top level of a generic test:

data_tests:
  - unique:
      where: "valid_to is null"

dbt was raising MissingArgumentsPropertyInGenericTestDeprecation, which misleads the developer into moving where under arguments: — which is wrong. The correct fix is to move it under config:.

Root Cause

In TestBuilder.extract_test_args(), the check for missing arguments property did not distinguish between actual test arguments and known config properties (CONFIG_ARGS like where, severity, tags, etc.). Any top-level key that wasn't config, column_name, description, or name triggered the wrong deprecation.

Fix

1. Exclude CONFIG_ARGS from the missing-arguments check in extract_test_args() so that known config properties don't trigger MissingArgumentsPropertyInGenericTestDeprecation

2. Emit PropertyMovedToConfigDeprecation for each CONFIG_ARGS key found at the root level of the test definition, guiding the developer to move it under config:

Test

Added TestMissingArgsVsPropertyMovedToConfig in tests/functional/deprecations/test_deprecations.py which verifies:

• PropertyMovedToConfigDeprecation fires for where at top level
• MissingArgumentsPropertyInGenericTestDeprecation does NOT fire

cc @dbeatty10

[ash2shukla]

Thanks for this work !
Please address following comments and we can merge it !

[ash2shukla]

I think the checks against CONFIG_ARGS here is redundant as CONFIG_ARGS and ("config", "column_name", "description", "name") are mutually exclusive.
Probably reword this block like following -

for k in test_args.keys():
    if k in TestBuilder.CONFIG_ARGS:
        deprecations.warn(
            "property-moved-to-config-deprecation",
            key=k,
            file=file_path,
            key_path=f"data_tests.{test_name}.{k}",
        )

top_level_keys = ("config", "column_name", "description", "name", *TestBuilder.CONFIG_ARGS)

if not arguments and any(k not in top_level_keys for k in test_args.keys()):
    resource = (
        f"'{resource_name}' in package '{package_name}'"
        if package_name
        else f"'{resource_name}'"
    )
    deprecations.warn(
        "missing-arguments-property-in-generic-test-deprecation",
        test_name=f"`{test_name}` defined on {resource} ({file_path})",
    )

[ash2shukla]

We dont need to patch profile target for this test.

[ash2shukla]

There should be exactly one event in this case, check for equality please == 1