fix: avoid false positive AmbiguousCatalogMatchError for case-only differences#12644
Open
chinar-amrutkar wants to merge 2 commits intodbt-labs:mainfrom
Open
fix: avoid false positive AmbiguousCatalogMatchError for case-only differences#12644chinar-amrutkar wants to merge 2 commits intodbt-labs:mainfrom
chinar-amrutkar wants to merge 2 commits intodbt-labs:mainfrom
Conversation
…fferences When a database has tables that differ only by case (e.g., 'Subject' and 'subject'), dbt docs generate incorrectly raises an error because the CatalogKey lowercases both the schema and table name, causing them to collide. This fix: 1. Adds a check to detect case-only differences between existing and new table entries 2. When such a case-only difference is detected, skip adding the duplicate to avoid false positive errors 3. Keeps backward compatibility by adding optional case_sensitive parameter to mapping_key and get_unique_id_mapping for future use Fixes dbt-labs#11776
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @chinar-amrutkar |
Contributor
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11776
Problem
When a database has tables that differ only by case (e.g., 'Subject' and 'subject'), dbt docs generate incorrectly raises an error because the CatalogKey lowercases both the schema and table name, causing them to collide.
Solution
This fix:
Checklist