Fix package version validation to handle missing property#12650
Open
benlevycmp wants to merge 4 commits intodbt-labs:mainfrom
Open
Fix package version validation to handle missing property#12650benlevycmp wants to merge 4 commits intodbt-labs:mainfrom
benlevycmp wants to merge 4 commits intodbt-labs:mainfrom
Conversation
Previously, the custom error would be skipped if the `version` property was missing entirely, rather than simply falsy, and only a cryptic `KeyError` would be raised
Contributor
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
2 tasks
Contributor
|
Thanks for opening this @benlevycmp ! Please do the following so we can review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12649
Problem
Previously, the custom error would not be raised if the
versionproperty was missing entirely, rather than simply falsy, and only a crypticKeyErrorwould be raised.Solution
Replaces direct key access with the safer
get()method.Checklist