Update docs and samples to use meta for alias and expression#399
Merged
Conversation
graciegoheen
left a comment
graciegoheen
left a comment
There was a problem hiding this comment.
I think we need to also nest meta under config!
Move `alias` and `expression` column properties under `meta` in the sample sources and add documentation in the README spec section. The code (PR #386) already reads these from `meta`, and the integration tests were updated, but the samples and README still showed the old top-level custom key format. Resolves dbt-core#12496
b-per
force-pushed
the
docs/move-alias-expression-to-meta
branch
from
7aafb67 to
e8b4822
Compare
|
@b-per this doesn't seem to work for partition definitions, for example this fails: partitions: &s3_parition_new
- name: partition_hour
data_type: timestamp
config:
meta:
expression: TO_TIMESTAMP(SUBSTR(metadata$filename, 3, 13), 'YYYY/MM/DD/HH24')I still have to use partitions: &s3_parition_new
- name: partition_hour
data_type: timestamp
expression: TO_TIMESTAMP(SUBSTR(metadata$filename, 3, 13), 'YYYY/MM/DD/HH24') |
This was referenced Mar 9, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aliasandexpressioncolumn properties undermetainsample_sources/snowflake.ymlmetapattern for custom column propertiesPR #386 updated the code to read
aliasandexpressionfromcolumn.meta, and the integration tests were updated accordingly, but the sample sources and README still showed the old top-level custom key format.Ref: dbt-labs/dbt-core#12496