Skip to content

Add +pre-hook and +post-hook to seeds config#189

Merged
joellabes merged 3 commits intodbt-labs:mainfrom
AaronCoquet-Easypark:main
Apr 16, 2025
Merged

Add +pre-hook and +post-hook to seeds config#189
joellabes merged 3 commits intodbt-labs:mainfrom
AaronCoquet-Easypark:main

Conversation

@AaronCoquet-Easypark
Copy link
Contributor

Resolves #122

Please let me know if I need to do something different!

@AaronCoquet-Easypark AaronCoquet-Easypark requested a review from a team as a code owner March 19, 2025 14:27
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AaronCoquet-Easypark the additions look good to me 👍

Could you please ensure that JSON keys are sorted by vscode-sort-json according to the rules in .vscode/settings?

@AaronCoquet-Easypark
Copy link
Contributor Author

All .json files have now been sorted ... even the ones that I hadn't touched previously.

@AaronCoquet-Easypark
Copy link
Contributor Author

@dbeatty10 Could you review again, please?

Copy link
Collaborator

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Havent reviewed the sorts closely (I think Doug just wanted you to sort the files you'd edited, but this is a bonus), but the direct modifications look good! thank you 🙏

@joellabes joellabes merged commit da8efc3 into dbt-labs:main Apr 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow post-hook as child of seeds

3 participants