Alias NodeRelation.schema_name to simply 'schema'

[peterallenwebb]

Resolves #106

Description

Alias NodeRelation.schema_name to simply 'schema'

Checklist

• I have read the contributing guide and understand what's expected of me
• I have signed the CLA
• This PR includes tests, or tests are not required/relevant for this PR
• I have run changie new to create a changelog entry

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[QMalcolm]

I'm somewhat skeptical of these changes. If they work though, amazing. We should get the conflicts resolved first and the actions reran. As it is currently, it looks like last July we had some test failures, but github has killed the logs on what those were.

[tlento]

I was just going to say exactly what @QMalcolm said. I just can't reason about what this alias magic from Pydantic will do in practice and I don't feel up to another deep dive into the Pydantic 1.10 codebase at this point.

Unfortunately our CI integrations between this repo and its various dependencies are lacking so we might be in a situation where we have to merge -> deploy -> test -> roll back.

[tlento]

Also, why are we making this change? I can't tell if the protocols need to be updated here, or if this is step 1 in a multi-step migration process that has to be merged and deployed in sequence in order to safely update the protocols, or what our final outcome is generally expected to be.

[tlento]

For some reason this is sitting in my review queue taking up cognitive space even though I commented eralier. I'm requesting changes just to see if I can alter the GitHub state, so if everybody else agrees that this is in a position to move forward please do clear that block rather than waiting for me to update my review.

In the meantime, it seems like this needs an update and CI re-run. If you could also add some context to the PR description around why we're making this change that'd help me expedite any follow-ups as well.