[Not for Review] Test that semantic_manifest.json parses to expected PydanticSemanticManifest#394
Draft
courtneyholcomb wants to merge 2 commits intopatricky/generate_example_json_for_new_fieldsfrom
Draft
Conversation
theyostalservice
force-pushed
the
patricky/generate_example_json_for_new_fields
branch
2 times, most recently
from
59afe6d to
29e2eca
Compare
courtneyholcomb
changed the base branch from
patricky/generate_example_json_for_new_fields
to
main
courtneyholcomb
changed the base branch from
main
to
patricky/generate_example_json_for_new_fields
courtneyholcomb
force-pushed
the
patricky/generate_example_json_for_new_fields
branch
from
68e1218 to
0fa65fd
Compare
courtneyholcomb
force-pushed
the
court/test-json
branch
2 times, most recently
from
01e4b5f to
a5de505
Compare
courtneyholcomb
commented
Sep 23, 2025
courtneyholcomb
changed the title
courtneyholcomb
changed the title
semantic_manifest.json parses to expected PydanticSemanticManifest
courtneyholcomb
force-pushed
the
court/test-json
branch
from
ecb8b14 to
ba6c956
Compare
courtneyholcomb
force-pushed
the
patricky/generate_example_json_for_new_fields
branch
from
0fa65fd to
709477c
Compare
…ticSemanticManifest This is intended to support development of YAML & JSON in other repos
courtneyholcomb
force-pushed
the
court/test-json
branch
from
ba6c956 to
0d6e6d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test to ensure that a given
semantic_manifest.jsonsuccessfully parses & passes validations. This is intended to support development of YAML & JSON in other repos. When you're at the point of having asemantic_manifest.jsonand need to test that it is valid, follow the steps below.To run the test:
semantic_manifest.jsonfile into a file within this repo.export SEMANTIC_MANIFEST_JSON_PATH=<path to your file, starting after dbt-semantic-interfaces>hatch run dev-env:pytest tests/validations/test_metrics.py::test_semantic_manifest_json_parsing_matches_fixtureIf helpful, for added thoroughness, you can aim to build a semantic manifest that will parse to match the one in the
fake_semantic_manifesttest fixture. This would be a fairly manual process requiring writing test YAML that should mirror that semantic manifest by combing through all the attributes in that semantic manifest, but it might help test thoroughness (ensuring no attributes were overlooked). If you decide to go that route, uncomment the assertion intests/validations/test_metrics.pyat the very bottom of the file (lines 1906-1908). Then follow the steps above.