Open
Conversation
plypaul
force-pushed
the
p/fix_cli_logging__01
branch
from
56e1854 to
e02c98c
Compare
plypaul
force-pushed
the
p/fix_cli_logging__02
branch
from
754e9e1 to
1238a0b
Compare
tlento
reviewed
Nov 18, 2025
Contributor
tlento
left a comment
tlento
left a comment
There was a problem hiding this comment.
This seems reasonable but I don't have full context on these package tests. Might be good to chat briefly just so I can get up to speed.
| @@ -1 +1 @@ | |||
| metricflow==0.209.0 | |||
| metricflow @ git+https://github.com/dbt-labs/metricflow.git@a430e4c2aeb77fe18d1c876326ef54ccf1cd464f | |||
Contributor
There was a problem hiding this comment.
Per the description, we don't want to merge like this, right? So this would be updated once the 0.210 or whatever release is deployed and then we'd roll this out with 0.211 (although since this is a package test it'll continue to run in the interim)?
plypaul
force-pushed
the
p/fix_cli_logging__02
branch
2 times, most recently
from
38ef62a to
7ff4a4d
Compare
WilliamDee
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1653 added a CI test for the
dbt-metricflowpackage in a release branch, but it's missing frommain. Note that due to naming update,dbt-metricflow's dependencies needs to be updated with a new release of MF, so this PR needs to be updated and merged only after the new release is available.