Selective aliasing for simple-metrics in WHERE filters#1943
Merged
Conversation
…d `InstanceSet.with_substituted_fields()`
plypaul
force-pushed
the
p/selective_simple_metric_alias_for_where_filter__01
branch
from
19fe992 to
1979afc
Compare
plypaul
force-pushed
the
p/selective_simple_metric_alias_for_where_filter__01
branch
from
1979afc to
a8bf695
Compare
plypaul
force-pushed
the
p/selective_simple_metric_alias_for_where_filter__01
branch
from
a8bf695 to
23407b8
Compare
courtneyholcomb
approved these changes
Dec 1, 2025
Contributor
courtneyholcomb
left a comment
courtneyholcomb
left a comment
There was a problem hiding this comment.
LGTM! Thank you!
plypaul
deleted the
p/selective_simple_metric_alias_for_where_filter__01
branch
courtneyholcomb
added a commit
that referenced
this pull request
Dec 4, 2025
courtneyholcomb
added a commit
that referenced
this pull request
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an update to #1941 to handle an edge case with manifests that contain a metric and an entity with the same name. Instead of aliasing all simple-metrics, the change is to alias only a specific one that is relevant to the containing branch in the dataflow plan. This limits collisions in the
SELECTstatement that is generated from the branch.Due to the large snapshot changes, please view by commit.