Bug fix: dropped metric YAML filters for cumulative & conversion metrics#1950
Merged
courtneyholcomb merged 5 commits intomainfrom Dec 16, 2025
Merged
Bug fix: dropped metric YAML filters for cumulative & conversion metrics#1950courtneyholcomb merged 5 commits intomainfrom
courtneyholcomb merged 5 commits intomainfrom
Conversation
Note the lack of WHERE filter in the rendered SQL
WilliamDee
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen a recent issue where metric-level filters in the YAML are not being applied for cumulative and conversion metrics. This PR adds tests to reproduce the issue and fixes it.
I recommend reviewing by commit - first commit demonstrates the issue, second shows how the change fixes it.