Remove all dbt dependencies from metricflow test environments#1967
Merged
Remove all dbt dependencies from metricflow test environments#1967
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
tlento
added
the
Run Tests With Other SQL Engines
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
approved these changes
Feb 3, 2026
tlento
force-pushed
the
add-sqlalchemy-sqlclient
branch
from
648f98f to
5a5ef7e
Compare
tlento
force-pushed
the
remove-dbt-deps-from-mf-dev-env
branch
from
22b9acb to
73a31ac
Compare
tlento
added
Run Tests With Other SQL Engines
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
Contributor
Author
tlento
changed the base branch from
add-sqlalchemy-sqlclient
to
graphite-base/1967
We no longer use dbt at all inside of Metricflow prpoer, so this removes all dependencies. The main changes of interest involve the updates to the pre-commit configuration. The original config was not package-specific since all critical dependencies were available from the metricflow environment, so we could run linters without any custom installations. Now that metricflow has no dbt dependency in its dev environment, mypy will no longer typecheck correctly via pre-commit in the dbt-metricflow package. Since mypy is the only affected item we work around this by invoking it from the makefile for dbt-metricflow, and otherwise excluding dbt-metricflow from the pre-commit execution.
tlento
force-pushed
the
remove-dbt-deps-from-mf-dev-env
branch
from
73a31ac to
d7ad588
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer use dbt at all inside of Metricflow prpoer, so
this removes all dependencies.
The main changes of interest involve the updates to the pre-commit
configuration. The original config was not package-specific since
all critical dependencies were available from the metricflow
environment, so we could run linters without any custom installations.
Now that metricflow has no dbt dependency in its dev environment,
mypy will no longer typecheck correctly via pre-commit in the
dbt-metricflow package. Since mypy is the only affected item we work
around this by invoking it from the makefile for dbt-metricflow,
and otherwise excluding dbt-metricflow from the pre-commit execution.