Add tests for nested offset metric queries with custom time grains#1988
Open
Add tests for nested offset metric queries with custom time grains#1988
Conversation
plypaul
changed the title
WilliamDee
approved these changes
Mar 10, 2026
…r nested offset metrics
plypaul
force-pushed
the
p/offset_metric_extra_metric_time_issue__01
branch
from
106df1f to
0302336
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests that demonstrate a bug in queries of an nested offset metric with a custom grain. This is a bug that existed prior to the FOJ optimization work. A PR to fix this issue is pending.