Add DataflowPlanOptionSet to group build options#1995
Merged
Conversation
theyostalservice
approved these changes
Mar 20, 2026
Contributor
theyostalservice
left a comment
theyostalservice
left a comment
There was a problem hiding this comment.
Thank you very much for breaking this up into separate commits!
plypaul
force-pushed
the
p/foj_count_optimization__18
branch
from
d89c4d4 to
01a3cb4
Compare
plypaul
force-pushed
the
p/foj_count_optimization__18
branch
from
01a3cb4 to
e938a50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
DataflowPlanOptionSetto group the options used when building a dataflow plan. As part of that change, it removes the builder’s_optimizationsinstance variable.It also fixes a caching issue where the selected dataflow plan optimizations were not included in the cache key. That fix changes some generated IDs in test snapshots, but does not change query semantics.