Avoid nested Hatch invocations in snapshot scripts#1997
Open
Avoid nested Hatch invocations in snapshot scripts#1997
Conversation
theyostalservice
approved these changes
Mar 21, 2026
Contributor
theyostalservice
left a comment
theyostalservice
left a comment
There was a problem hiding this comment.
thanks for setting this up for reviewing by commit; it made it much more reasonable to review!
| run_command( | ||
| f"hatch -v run {hatch_env}:pytest -vv --log-cli-level info --use-persistent-source-schema " | ||
| "tests_metricflow/source_schema_tools.py::populate_source_schema" | ||
| if test_configuration.engine not in ENGINES_WITH_PERSISTENT_SOURCE_SCHEMAS: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently updated my dev environment (e.g. updated package versions, changed how
hatchwas installed) and saw that there was an error runningmake regenerate-test-snapshots. The issue was due to nestedhatchinvocations: the script was called using ahatchcommand, and the script callshatchcommands using a different environment.This PR removes dependencies from the top-level script so that it can be run without
hatch. Please view by commit.