Open
Conversation
Owner
|
Thanks @dzanahmed ! Just an FYI, translation changes take more time to review, and I am not sure exactly when I'll have the bandwidth to review (just to st expectations). But truly appreciate the addition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Added Bosnian language translations.
Hi,
I'm a researcher from Bosnia and Herzegovina, and a longtime fan and user of gtsummary. Thanks @ddsjoberg and all the rest of the team for building and maintaining this awesome package.
Given that I sometimes need to provide outputs in local language, I found myself translating the outputs through some scripts, and then I realised that I can contribute by adding my language to the package, which would be useful for me, and possibly other researchers from the Western Balkans region.
I've followed this pull request: #1302 and gone through the same steps.
Although Bosnian is spoken by some 3 milion people, our language is very similar to Croatian, Serbian and Montenegrin (when combined, this gives about 20 milion speakers worldwide; the languages have different names, but we understand each other 100%).
If the translation needs to be validated by another person - any of native speakers of these languages would be able to do so.
Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()usethis::use_spell_check()runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.mdwith the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).usethis::use_version(which = "dev")usethis::use_spell_check()again