debezium/dbz#36 Add support for tls #199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…main.url` and use `ingress.tls.enabled` to choose the url schema. Signed-off-by: Fiore Mario Vitale <[email protected]> Co-authored-by: Chris Bowles <[email protected]> Signed-off-by: Fiore Mario Vitale <[email protected]>
jpechane
reviewed
Jan 8, 2026
| Get the domain URL, with backward compatibility to deprecated .Values.domain.url. | ||
| */}} | ||
| {{- define "debezium-platform.domainUrl" -}} | ||
| "{{ include "debezium-platform.domainScheme" . }}://{{ include "debezium-platform.domainName" . }}" |
Contributor
There was a problem hiding this comment.
Is it OK to use it here when debezium-platform.domainName is defined after this one?
Member
Author
There was a problem hiding this comment.
Yes.
Helm templates are processed in two phases:
-
Parse phase: All template definitions are collected and registered, regardless of their order in the file
-
Execution phase: Templates are actually invoked and rendered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the work originally proposed in #172.
The original PR was closed and the fork later removed, so this reworks and extends that contribution.
closes: debezium/dbz#36