-
Notifications
You must be signed in to change notification settings - Fork 0
feat: implement automated PR preview system with Fly.io deployment #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ief extension PR previews on Fly.io
… for Debrief extension environment setup
…ith automated deployment and cleanup scripts
…ed Docker integration and verification
…PR previews, cleanup, and build validation
…Hub Actions workflows - Update pr-preview.yml to use flyctl commands instead of fly - Update pr-cleanup.yml to use flyctl commands instead of fly - Remove version specification from setup-flyctl action - Add CLI verification step to ensure flyctl is properly installed
…and timeout handling - Increase health check grace period from 10s to 60s to allow code-server startup time - Extend health check timeout and intervals for more reliable startup detection - Add deployment timeout with fallback status checking - Add manual app verification with curl test after deployment - Reduce wait-timeout to 300s to prevent excessive hanging - Add verbose logging and timestamp tracking for deployment monitoring
… registry issues - Add retry logic for @vscode/vsce installation with multiple fallback methods - Support both global and local vsce installations via npx - Add comprehensive error handling and verification steps - Update both pr-preview and ci workflows with resilient package installation - Handle npm registry access issues and 403 errors gracefully
… improve efficiency - Split pr-preview.yml into build-and-test + deploy-preview jobs - Use GitHub Actions artifacts to share extension package between jobs - Remove PR build duplication by having ci.yml only run on main branch pushes - Fix flyctl deployment parameter issue (remove --no-public-ips false) - Reduce total CI minutes and improve parallel execution - Maintain same functionality with better separation of concerns
🚀 PR Preview DeployedYour PR preview has been successfully deployed to Fly.io! 🌐 Preview URL: https://pr-4-futuredebrief.fly.dev 📋 Details:
🔧 What's included:
💡 How to use:
This preview will be automatically updated when you push new commits to this PR. |
…uration improvements - Increase VM resources: 1GB→2GB RAM, 1→2 CPUs for code-server requirements - Remove conflicting processes section from fly-template.toml to use Dockerfile CMD - Add more lenient health checks with longer grace periods (60s→120s) - Add TCP health check as fallback for slow HTTP startup - Use immediate deployment strategy to force machine restart - Add comprehensive logging and status checking for better debugging - Extend app startup timeout to 45s and response timeout to 120s - Support partial deployment status reporting
…nfiguration (since we couldn't get our docker to pass these health checks)
…ice checks for improved deployment stability
…uration for Debrief extension
…rkflow in deployment configurations
🧹 PR Preview Cleaned UpYour PR preview environment has been automatically destroyed. ✅ Cleanup successful!
All associated resources have been removed from Fly.io to optimize costs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a comprehensive automated PR preview system that deploys VS Code environments with the Debrief extension to Fly.io for every pull request.
Key Features
Implementation Details
Files Added/Modified
.github/workflows/pr-preview.yml- Main deployment workflow.github/workflows/pr-cleanup.yml- Automatic cleanup on PR close.github/workflows/ci.yml- Build validation and health checksDockerfile- Code-server environment with extensionfly-template.toml- Dynamic Fly.io configuration templatescripts/create-pr-app.sh&scripts/destroy-pr-app.sh- Deployment utilitiesdocs/ci-pipeline.md- Comprehensive documentationTest Plan
pr-{number}-futuredebriefPerformance Targets Met
Ready for production use with
FLY_API_TOKENGitHub Secret configuration.