-
Notifications
You must be signed in to change notification settings - Fork 10
trigger areas #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
trigger areas #290
Conversation
|
perhaps rather than requiring the trigger area to have a then we can specify the default collision layers differently. we could also update the gltf reader to specify that that would avoid all changes on existing components / behaviours and would give us good default behaviour for the new component. |
robtfm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- we should ensure that triggers are triggered even if the object "passes through" the target in a frame. this would require special handling for tweens. or explicitly say that this doesn't trigger (which would be a shame)
- we should report the position of the trigger as well (at first point of contact) for the case when the entity with the trigger has a tween
- if an entity has collision=physics and trigger=player set to the same mesh, should we fire the trigger when player touches? from the example it appears so, this should probably be explicitly mentioned either way
| - `position`: The position of the entity that triggered the trigger | ||
| - `rotation`: The rotation of the entity that triggered the trigger | ||
| - `scale`: The scale of the entity that triggered the trigger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suggested using a transform directly here, but i'm not sure we can actually do that since we don't have a PbTransform message type...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same would apply to the fields triggeredEntityPosition and triggeredEntityRotation that I just added
If we change the 3 above fields for a Transform, then we should do the same with the triggered entity
Co-authored-by: Mateo Miccino <mateomiccino@gmail.com> Signed-off-by: Nicolas Earnshaw <nearnshaw@decentraland.org>
Signed-off-by: Nicolas Earnshaw <nearnshaw@decentraland.org>
kuruk-mm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🙌
Co-authored-by: Pravus <pravusjif@gmail.com> Signed-off-by: Nicolas Earnshaw <nearnshaw@decentraland.org>
Co-authored-by: Pravus <pravusjif@gmail.com> Signed-off-by: Nicolas Earnshaw <nearnshaw@decentraland.org>
Co-authored-by: Pravus <pravusjif@gmail.com> Signed-off-by: Nicolas Earnshaw <nearnshaw@decentraland.org>
Co-authored-by: Pravus <pravusjif@gmail.com> Signed-off-by: Nicolas Earnshaw <nearnshaw@decentraland.org>
Co-authored-by: Pravus <pravusjif@gmail.com> Signed-off-by: Nicolas Earnshaw <nearnshaw@decentraland.org>
No description provided.